Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

using a proper machine index to avoid port collision #233

Merged
merged 1 commit into from
Jan 25, 2020
Merged

using a proper machine index to avoid port collision #233

merged 1 commit into from
Jan 25, 2020

Conversation

chanwit
Copy link
Member

@chanwit chanwit commented Jan 25, 2020

This PR uses a new machine index to improve machine creation logic so that machines created from the different specs, but have the same index could avoid port collision.

Fixes #232

/cc @cdavisafc

@chanwit chanwit self-assigned this Jan 25, 2020
@chanwit chanwit added the kind/bug Something isn't working label Jan 25, 2020
@chanwit chanwit requested a review from palemtnrider January 25, 2020 16:01
palemtnrider
palemtnrider approved these changes Jan 25, 2020
View reviewed changes
Copy link

@palemtnrider palemtnrider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chanwit
Copy link
Member Author

chanwit commented Jan 25, 2020

Thank you @palemtnrider

@chanwit chanwit merged commit 86054cb into weaveworks:master Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@palemtnrider palemtnrider palemtnrider approved these changes

Assignees

@chanwit chanwit

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port conflict trouble when separate machines are specified
2 participants
@chanwit @palemtnrider